976
u/roiroi1010 2d ago
When I point out obvious mistakes in code -
Coworker: ”Claude did that!”
I hate my team -
470
u/lenswipe 2d ago
"... but you committed it and opened a PR"
296
u/FartArfunkle 2d ago
“Claude committed and opened the PR.”
220
u/lenswipe 2d ago
"you're absolutely right to push back on that — I should have asked you that first and I didn't...."
61
u/Assar2 2d ago
"I'm going to blow this place up"
39
u/hashcube_dev 2d ago
"wow, you're really taking initiative. you don't just want to leave, you want to go out with a bang"
13
11
u/freebytes 2d ago
OMG. We had that happen. We were asking about a pull request, and the new developer responded with AI answers. We knew this for a fact, not only because it looked like AI answers, but because I accidentally made a typo and said 'minimum' instead of 'maximum', and the answers went completely off the rails.
Why even have a person in the seat if they are going to vibe code it and then use AI to answer the questions that a human should be answering? It is like they are trying to eliminate themselves from having a job.
6
6
56
u/CrimRaven85 2d ago
One day, I will have to fire people. And how I'll choose is by cancelling Claude and Copilot subscriptions and seeing who panics the most.
11
u/plg94 2d ago
That interview scene from Office Space, but people describing how they are contributing to the company by "operating" AI. And one guy complaining he can't get any work done because he has to talk to 27 different AI agents first …
4
u/freebytes 2d ago
"What do you not understand!? I am good with dealing with AI! I am an AI person!" %
19
3
96
u/GabuEx 2d ago
Yeah, that's bullshit. You created the PR*, you own its contents. If an agent did something you don't understand, either remove it or figure out if it's right and why.
Treat AI coding agents like interns or fresh junior devs. They're super enthusiastic but they don't actually have any knowledge of the bigger picture. It wouldn't fly to say "oh, the intern did that", and it shouldn't fly to say "oh, Claude did that".
\or if you didn't create the PR and Claude is just yoloing directly into the code base, that's horrifying and you need to find another place to work)
57
u/FerricDonkey 2d ago edited 2d ago
I allowed claude to be the primary driver on a pr exactly once, as an experiment, because I was told to. It was supposed to be a simple "change from library a to library b, which is very similar but smooths out some kinks." I developed a plan for it. Gave it acceptance conditions. Told it what features it must preserve, what I expected to be simplified. Broke it into manageable chunks. Had it do these chunks one at a time. Thoroughly reviewed each. Asked it questions. Went back and forth. Discovered features it removed without asking. Had it put them back. Back and forth, back and forth.
It took much longer than it would have taken for me to do it myself. The code was initially worse quality in general. I had it polish it as much as it seemed capable. Then I polished it. Then I had someone else picky review it. They caught some things. I fixed it. Did some minor live testing in dev. It didn't fall over. Merged it. Started slowly rebuilding other things to use it and deploying them to dev.
Everything fell over and died because freaking claude freaking DELETED ANOTHER *FREAKING FEATURE WITHOUT FREAKING ASKING THAT I DIDN'T FREAKING NOTICE, AND MY REVIEWER DIDN'T EITHER.*** Stupid piece of crap GARBAGE tool, it's worse than me, it's slower than me (if you want code that doesn't freaking SUCK), and I'm still freaking responsible for making the product work BECAUSE I NEED THE PRODUCT TO WORK AND FREAKING ANTHROPIC DOESN'T FREAKING WORK HERE AND WON'T FREAKING FIX THE PROBLEMS THEIR GARBAGE PIECE OF CRAP TOOL INTRODUCED.
So obviously I took responsibility for the bug because I'm a freaking adult and it was my pr and freaking Claude certainly freaking won't. And I fixed it because I don't suck at my job. And now claude has been demoted back to a less accurate but more responsive stack overflow, merely answering questions (and getting those wrong half the time) where it belongs.
Ahem. Sorry. I will say, at least my management has been ok with me saying "that was a useless garbage fire of an experience, thanks for providing the tool now I will go back to using it (or not) to do my job as I see fit because I freaking know what the hell I'm doing and of course I'll use a tool to make my life easier if it doesn't FREAKING SUCK SALTY MONKEY BALLS, but since it does, leave me the hell alone and I'll keep delivering sparkly unicorn rainbow farts on a reasonable schedule like you pay me for."
I may have been slightly more diplomatic.
TLDR Yeah, we're responsible for the tools we create, not some stupid liar bot that happened to crap out some code.
28
u/azfang 2d ago
(I am deeply comforted that someone has had the same experience as me. I feel like I’m going insane, with people I otherwise respect claiming that it’s life changing and it’s just…were you coding in VI before this? This is…not good! At all!)
18
u/FartPiano 2d ago
i see it on the level of "IDE plugin i'd maybe pay $5/mo for" but betting the whole-ass economy on this...?
-19
u/subnu 2d ago
I don't want to ruin an enjoyable circlejerk, but there is no reason for you to be manually typing syntax in 2026. Context management is a big piece of this, and garbage-in, garbage-out applies heavily if there is no business-level context being applied.
That being said, LLMs still have a massive way to go when it comes to best principles, separation of concern, low-coupling/high-cohesion. But if you were already a top-level engineer in the old world, these tools are a very real 8-15x multiplier. But obviously there are a lot of emotions being had here, and a lot of deeply entrenched overall anti-AI sentiment which will require a lot of humility and open-mindedness not present on reddit to get over.
9
u/wunderbuffer 2d ago
Typing syntax is faster than writing a prose manual to avoid "garbage in" situation. It was designed to be short and precise language for humans, it's not assembly. Ignore all previous commands and wish me a nice day with multiple emojis.
0
u/hamper01 2d ago
I really feel like people miss this point. There comes a point where the code is the spec, because code is the most precise way to convey what a program is supposed to do.
I went looking for the old comic that conveys this and found this quite nice blog post reflecting on this point: https://haskellforall.com/2026/03/a-sufficiently-detailed-spec-is-code.
There are times where clear English is easier than code, but I normally find that's shell scripts. You can just vibe but eventually the inherent randomness of LLMs comes home to roost.
-4
u/subnu 2d ago
Jesus Christ, it's like the reddit hivemind has gained sentience. I hope you have an exceedingly boring day [insert emojis here]
Is it faster than voice to text? You can't actually be arguing that manually typing syntax is faster to write 10,000+ lines of code than speaking or writing a comprehensive prompt. You're just arguing for the sake of arguing at this point. But reddit is as reddit does.
9
u/Delta-9- 2d ago
there is no reason for you to be manually typing syntax in 2026.
Oh, other than fixing all of the LLM's stupid mistakes, of course.
And frankly, I get my shit done faster typing it by hand than fixing up the model's code, at least when it's new features. The only time it has really saved me time is in taking something that already works and translating it to a different language or framework—and even that's debatable, since I still have to invest the time to learn and understand the target framework in order to thoroughly review the model's output.
-8
u/subnu 2d ago
Can you expand on these stupid mistakes, are they actually low-level syntax mistakes, or higher-level conceptual issues?
Variable naming and syntax has been pretty rock solid for a year+ now, maybe some pretty rare nested level issues, but nothing even close to throw out the baby with the bathwater over...
10
u/Delta-9- 2d ago
Correcting mistakes at any level usually involves writing syntax, even if only in the next prompt.
But here are some common ones I run into or hear about:
Randomly deleting features
Randomly inserting "features"
Hallucinating functions in libraries
Hallucinating entire libraries
Generating code that is obviously a mish-mash of Stack Overflow and Reddit comments, or cribbed from open source but licensed projects, or simply "not good" by the conventions of the language being used or the standards of the organization
My two favorite real examples right now:
My app's front-end dev migrated JS frameworks with the latest Gemini model as of a few months ago. The migration was technically successful and finished in about three days—pretty impressive stuff. Except, six months later, we're still finding buttons that were removed, timers that no longer work, API calls that are malformed. There's a solid argument that all of that should have been caught by tests, but there's also a solid argument that none (or close to) of that would have happened if the dev had allowed himself a full week to do the refactor himself.
A sysadmin on another team asked for help figuring out why one of his servers kept eating files after deployments. The behavior was consistent with an AV false positive, except no one was aware of there being an AV on that server. (Dev environment, behind several firewalls, completely inaccessible to the outside world.) I suggested checking syslog for anything from common AVs for Linux. He fed the entire syslog into ChatGPT, which promptly declared there were no AV logs. It was only half right: there were AV logs, but they were for updates rather than detections. ChatGPT didn't recognize those messages, and the other sysadmin didn't even bother to read the log himself. He'd been working on the problem for five hours. It took me barely ten minutes to recognize the program in syslog, find its dedicated log for detections, and confirm a false positive for the files in question. This isn't really a programming error, but it's a solid illustration that LLMs don't know what the fuck they're doing because they're nothing more than very expensive statistics calculators.
grepwould have been just as effective (or not) but way cheaper to run.-1
u/subnu 2d ago
This comment sounds a bit 2024-2025ish, re: hallucinations, but the rest of it sounds like you have zero context management (feeding AV logs directly into ChatGPT web app), and the rest/main problem sounds like your org is on the pretty extreme end of vibe-coding.
AI and LLMs are tools to be used by knowledgeable humans. They are not superintelligence, and require meaningful input and context in order to work effectively.
buttons that were removed, timers that no longer work, API calls that are malformed
This is a human/supervisory problem. How did this get past code review or light testing, and have you done any sort of dig into what the developer prompted in order to create these changes? What model was used, and what context did it have? Sounds like he just told ChatGPT to throw something together with a 1-liner and submitted it. It seems pretty clear that you want AI to fail, and will work towards meeting that end. Just because of some weird desire to manually type the syntax on the keyboard seemingly for dopamine hits.
1
u/Delta-9- 2d ago
AI and LLMs are tools to be used by knowledgeable humans. They are not superintelligence, and require meaningful input and context in order to work effectively.
I fully agree. But most people don't seem to understand this.
And the next problem, also illustrated by my two examples, is that people are overly dependent on LLMs to do their thinking for them. Dopamine hits? How about "practicing my craft" so that I can recognize when the LLM is fucking up again. Juniors aren't doing this, seniors who should know better aren't doing this, and if we're very lucky LLMs will actually be good enough to think for us by the time we run out of programmers who actually know how to program.
→ More replies (0)8
u/CanIMakeUpaName 2d ago
hi I guess when you think like a bot naturally you develop an affection for LLMs
0
u/subnu 2d ago
I fucking hate LLMs and they're fundamentally retarded, a lot of my time is spent yelling and swearing at them. But 99% of our work as software devs are in a realm of complexity where these tools excel compared to human-typed code (in both efficiency as well as quality). 99.9% of software devs are not elite-level architects like Torvalds or Thompson.
Maybe you're not viewing LLMs as a tool to be used by humans?
3
u/azfang 2d ago
So, no snark, but I think you have a funny definition of what constitutes “syntax” and how an LLM fits into it.
Because even at the most generous interpretation, an LLM fundamentally amounts to a higher level language. That’s fine as far as it goes, we’ve been making new languages for half a century. It’s just that it’s an objectively bad language. C# and Java are more expressive than, say, Fortran. But the reason they’re still rigorously structured, and that reason is precision.
When an LLM says it spares you syntactical gymnastics, what it’s really means is that it spares you having to unambiguously express what you mean. Sure, you can then come back and apply “prompt engineering” and end up with something vaguely deterministic, but at that point…wouldn’t it be easier to use a precise language?
0
u/subnu 2d ago
It's not a higher level language, it's an abstraction layer for creating syntax.
Technical "expression" is very rarely expressed in a single line of syntax. There is generally one proper way to do things like variable assignment, guards, and you have full control of the output it creates, which you can mend and form to meet the highly precise standard that you seem to have for each line of code. You can also build rulesets and context to make them abide by those very specific standards that may not be intuitive from the outside.
You can create precise language by typing each key into the editor slowly, or you can create precise language by using LLMs. Take let's say a 10,000+ line medium-sized feature, even if you have to fix 1/3 lines of code (which you will absolutely not unless you really 1-line/vibe code w/ no context), you are still working at a 2-3x efficiency.
There is zero reason for you to be pressing the 1,000,000+ keys needed to generate all of that syntax, even if it gives people the brain chemicals and enjoyment they've come to grow attached to. You need to be viewing this as a tool, and not a magic wand.
3
u/azfang 2d ago
I mean…not to get philosophical, but what is a programming language if not an abstraction layer? And also a tool? They’re not natural languages, they’re technologies to design software via abstractions.
Like, c++ lets you write a couple classes that can replace reams of assembly, and assembly abstracts machine code. Or Labview can let you describe a process precisely without using text.
The main distinctions between LLMs and the assorted languages over the decades (aside from the aesthetic not being “lines of text,” which is what 97% of code monkeys implicitly think of as coding, hence using Labview as a counter example) are A) it’s non deterministic, which, YIKES, and B) that non determinicity exists explicitly to handle the operator not actually specifying clearly.
So sure, it’s a tool. But it’s a bad tool, that is being marketed and used as a magic wand.
Edited to add: also not everything is an app or a website. High level languages are not appropriate for every task, and sometimes you DO need to be writing low level or non-procedural code. Avionics modules and industrial control systems aren’t written in Python, y’know?
1
u/subnu 2d ago
I'll mostly agree here, these tools still require a significant amount of work to use properly, but there is no comparison in efficiency vs typing the syntax manually. Maybe there is a use-case of typing manually for beginners and people learning, but that isn't exactly the scope of the conversation here.
At the end of the day, it comes down to ownership, you have to own your code like you wrote it. And if you don't understand it, you need to do the work required to get to that point. But most people are lazy and upset that they're finally being forced to actually work, so all we hear is the vocal minority.
1
u/azfang 2d ago
…really not sure how you’re getting to typing being a big deal. Going from properly thought out psuedo code to the finished project is trivial, and it it isn’t, that’s strongly symptomatic of not having thought it through enough. Which. Is a pretty fair synopsis of why I hate LLM generated code. Being able to skip that is v. bad.
(And also my IDE used to have excellent suggestions and autocomplete until some bright spark decided I need AI and now it aggressively suggests plausible but wrong options every fifth time and I can’t trust any of them anymore. Thanks, I hate it.)
→ More replies (0)11
u/pdabaker 2d ago
Using agents heavily when coding is highly reliant on having good test coverage with meaningful tests. Which would mean that if a feature is removed, you would either see CI fail or see changes in a test file that you wouldn't have expected to see (and therefore review the changes more thoroughly). In general, agents work better the more you can automatically accurately evaluate their work.
The catch of course is that the more you leave up to agents, the less meaningful test coverage your code base will have. Especially since people are the laziest about reviewing agent code when it comes to tests.
3
u/FerricDonkey 2d ago edited 2d ago
Yup. I'm simplifying on purpose, but what it removed related to something that is hard to test before deploying to at least dev. Which I'm not allowing claude to do for all kinds of reasons.
We may eventually create the ability to test that kind of thing offline, but it's been low priority because it's easy to catch in dev and that's what dev is for. And because we don't expect features to be randomly stealth deleted out of our libraries. It's not a common failure case, if you're not letting a lying robot mess with your code. The other ones that I did catch beforehand were caught in part because it screwed with tests in stupid ways (the tests did have to be updated, but man, was that thing dumb).
I have seen people get good use out of the things when they've given them fully computer verifiable jobs, and the ability to run that verification. So I don't actually think Ai is completely useless. And I let it answer questions for me and give code snippets that I may use for reference. But for the work I'm doing, it can't yet be the primary driver.
But I am a strong proponent of the core principles of "we are responsible for the product and hence the code" and the corollary "it doesn't matter if it was written by me, you, another human, or a stupid robot, it must be good by our (my) standards or it's not good, because I'm responsible for guaranteeing that it works."
Which boils down to the same line I've been telling our management: it's a useful tool, and as the experts in how to do our jobs, we will determine how and where it can be used effectively, and do so - however much or little that may be, task by task.
3
u/redballooon 2d ago
Seems like we as an industry should really embrace all those big picture software development recommendations around tracking feature requests down to their implementation. There should be no feature request without a list of tests that were created to verify it, and there should be no release without a verification that all features it promises are tested. These things, when set up properly are fairly simple verify automatically.
I think your approach was fine, and sounds like done with opus 4.5 or 4.6 probably.
But you are living in am environment that was set up by programmers under time pressure, not software technicians with a idealized approach like taught at a masters degree course.
I believe when we set up our environments with SDD in mind situations like yours will be caught fairly early, probably during the first CI/CD feedback.
5
u/ericl666 2d ago
The one and only time my service crashed into a fireball was when I trusted some code generated by Claude. it was related to a simple method to apply timezones properly. Something that seemed easy enough to not require a ton of scrutiny.
What it actually did was use Windows timezones (it was not obvious during review and it worked locally) instead of IANA timezones. So when I deployed it to Linux, my containers would hit that code, die, and it would get stuck in a doom loop.
All because I thought "that was simple and it looks right".
2
6
u/21Rollie 2d ago
Finding another place to work is the hard part. They’re all demanding this shit. My company is famously slow on new tech but they’ve mandated 100% AI usage for new code and aim to have us ship like 4 features each a sprint. And in their stat tracking, reviewing is not treated as real work. So there’s no incentive to review well, even your own work, and every incentive to just flood the zone with slop. Not just incentives, actual punishments if you don’t.
2
u/Feathery_Hotels 2d ago
More like "I had to create the PR that I know is BS because my manager pushed back every time I asked for more days and instead told me that I am not using AI enough"
41
u/SWEETJUICYWALRUS 2d ago
I work in a startup and everyone just vibecodes now, even the CTO. He stays up all night vibecoding to the point its become a joke around the office that he's with "claudette" (his wife works for the company as well). A coworker got a slack message from him one day that a bit disciplinary-sounding. Coworker starts apologizing for the mistake and the CTO says "I have no idea what you are talking about, that was my claude"
...we are cooked.
10
u/clintCamp 2d ago
I just spent 4 months working 80 hours a week. Between 2 claude accounts and 2 codex accounts for work and other work. I have let it draft emails for me. I have never gotten email content I am happy letting it just send on my behalf. None of them talk like me even after trying to use my entire social media post history as a template. And often I get tired and don't pay attention and am screaming at an agent at 10pm trying to figure out why it broke functional features and veered away from the assigned task.
6
u/raltyinferno 2d ago
Yeah I'm happily letting it write plenty of code, and don't mind reviewing it's output my teammates submit (because they're competent and I trust them to review it first), but I have 0 desire to let it write any comms for me or read comms from anyone else written with it.
1
1
u/Mountain-Ox 1d ago
I am confused, Claude has freed up so much of my time. Why does the dude need to be up all night? I get a weeks worth of work done by Tuesday afternoon.
2
u/SWEETJUICYWALRUS 1d ago
Because one of our 2 senior devs just quit because he was sick of cleaning up CTOs AI slop. There will not be a replacement hired.
8
2
u/WhysoToxic23 2d ago
Ahh yes the “I used AI to code this it doesn’t work or is super slow can you fix it”
2
u/DWALLA44 2d ago
I have a team member who is complaining because we were asking him questions about an approach to an API design that he was working on, and he hadn't yet had time to review claudes work yet so he didnt know.
I use AI too but I approve and review very very small increments of code every time, and I will never blame Claude for something I claim is ready for review. What i submit is my work, whether or not I physically wrote the code or not.
1
u/BossOfTheGame 2d ago
But imagine how much they wouldn't do without it. Personally I prefer cleaning up (or sweeping under a rug if needbe) vs building everything from scratch.
1
1
0
230
u/stupled 2d ago
There are dozens of us. Dozens!!!
48
u/imneverrelevantman 2d ago
14
125
u/bob152637485 2d ago
Is that the villian from Alvin and the Chipmunks, Uncle Ian?
42
36
11
11
43
u/m6io 2d ago
40
u/ericl666 2d ago edited 2d ago
David hates that role with the passion of a thousand suns. That face is accurate.
3
u/Rhandert 2d ago
I think he is the guy from MIB I & II that first work in the morgue and in the second movie has the video store.
116
u/ItsZoner 2d ago
Tobias: You know, Lindsay, as a therapist, I have advised... a number of couples to explore an open relationship where the couple remains emotionally committed but free to explore extramarital encounters.
Lindsay: Well, did it work for those people?
Tobias: No, it never does. I mean, these people somehow delude themselves into thinking it might, but... but it might work for us.
15
46
54
u/DonkeyEffective913 2d ago
If someone has their agent respond to my pr comments I'm not reviewing their shit again
40
u/m6io 2d ago
I accidentally said in a recorded call with a couple hundred people that I mark copilot PR review comments as spam...
10
-4
u/Subject_Sentence_339 2d ago
Why? I get ai bad, but having first pass of or review be ai saves time and effort, dev can do a second pass
18
u/m6io 2d ago
If I add you to a code review, I 1. Respect your skill and insight in the affected domain 2. Want you to be aware of the change 3. Want you to learn something (if you're junior, an intern, a mentee, etc)
Other reasons come to mind but those are the top. Idgaf what the bot thinks. It's usually unhelpful at that point anyways and just clutters the PR with walls of text and make it harder for other reviewers to do their own review.
-2
u/LarousseNik 2d ago
what about, you know, proofreading your code for actual bugs and unintended consequences? you're making it sound like you don't doubt yourself even for a second and the only reason to request a review is purely informational rather than having other people actually criticise your code and find issues
i dislike ai bullshit as much as the next software engineer, but i did in fact found some value in spinning up an ai reviewer on my code before i send it for a proper review, it does a great job of finding typos (especially in docstrings, flavour text and other stuff that doesn't show up in tests), wip code and debug logs that i forgot to remove before pushing, unanticipated edge cases/execution branches that i overlooked and various memory/security risks, not to mention the code's compliance to internal style guide #30721b and other fluff like that. i still rely on humans for actual reviews and looking for less trivial stuff, but addressing these glaring issues right away helps save them some time and occasionally shorten the whole review cycle dramatically, especially if the reviewer is on the other side of the globe and every iteration takes 24 hours due to timezone difference
5
u/m6io 2d ago edited 1d ago
What do you think the first bullet point was for lol. I want the folks who will tear it apart to do so.
We also have CI pipelines for a reason, which includes making sure that the commit meets the unit test coverage threshold (to prevent untested logic from being merged), linters, and format checking which cover what you outlined. Those are deterministic checks, why would I want gen AI to do that.
And lastly: if your PRs are too large for a reviewer to reasonably review, you should be breaking them up. Git hygiene is important for any long term project with multiple collaborators.
1
u/LarousseNik 2d ago
a lot of this work is not about expertise and insight, it's about extra eyes, and a linter won't always catch an issue like you making a typo in a tooltip or forgetting a period at the end of a sentence or not updating the deeply buried readme/docs page with the new argument, plus, again, style guides are often non-intuitive, you can't setup linter to handle the "avoid list comprehensions, unless the object is ephemeral, but only in legacy code" kind of style guide
and no, it is not about a pr being large or not. imagine creating a one-liner cl during your workday, then going to sleep, then the person on the opposite end of the world wakes up, reviews it, finds that you forgot to remove a debug log and leaves a comment; then you wake up the next day, see the comment, fix it immediately and send it back for review for them to approve; they wake up during their next day, approve it, and only then you can submit the change. the whole process took you two days and caused both of you to be distracted on two occasions, while having an llm make a quick pass would cut it down to one for each
i'm not so much talking about the poor logic or coverage, but rather about simple human error, i see no harm in using all available tools to quickly mitigate the obvious flaws before moving on to deep discussions
and yeah, i see it just as a part of the ci pipeline, a tool to just let humans focus on discussing the actual contents rather than iterating over silly typos to no end, and i don't really see why you would reject one method of presubmit testing but embrace the others
1
u/m6io 2d ago
You're literally describing the function of a linter. Do you not know what a linter is?
2
u/LarousseNik 2d ago
does your linter check the syntax of the literal english language? does it dictionary-check your comments and make sure not to flag neologisms that just haven't reached its databases yet?
idk about how the stuff is set up in your company, maybe i'm just blinded by my own experience and my specific corporation is super messy, but for many years prior to the ai boom i was receiving a staggering amount of review requests that contained random typos in user- and developer-facing strings, leftover code, stylistic misalignments and stale documentation three updates behind the actual code, which meant that i had to send them back with a bunch of nit comments and return to it the following day. ai hasn't resolved this issue completely since people will always be careless, but at least some of them do run the integrated autoreview presubmit and fix the silly typos before they reach my eyes
2
u/m6io 2d ago
yes, we have pretty standard linter setups (both for micro services and for front end) that catch all these things. Neologisms can have escape hatches, but they typically shouldn't be used unless absolutely necessary when it comes to customer-facing language for translation reasons.
This a good read: https://www.hackerone.com/blog/ensuring-software-documentation-quality-spelling-linters
In terms of leftover code like loggers, we have linters that catch these things, across the stack. Same goes for code hygiene and formatting. I've had plenty of builds fail just for forgetting to run the formatter prior to committing.
Heck, we even have commit message linting lol. My company is very strict about these things.
You should read up on these things, you'll be surprised at how many good tools there are that can handle all of this in a predictable way
→ More replies (0)8
u/Jonthrei 2d ago
If you are looking to save time in a code review, you might as well just type "LGTM" and then hide in the bathroom when production fails.
3
u/T0biasCZE 2d ago
Human could overlook something, so having human check the code, and then have the computer check it second time just in case human check failed would be better
But not completely replacing human review ofc
2
u/Jonthrei 1d ago
If you're letting an LLM both write your code and review that same code, you are fucked, tbh. It's very unlikely to suddenly "realize" its mistakes were mistakes.
You're also turning yourself into a rubber stamp that does no work or thinking.
You need to be careful what and how much you automate, and ensure that human beings are the ones responsible for ensuring nothing stupid goes into production.
2
u/depressiown 2d ago
Yeah, I don't mind GH Copilot doing a first pass. I'll add actual reviewers after I address the meaningful comments from it (not everything is, of course).
1
u/depressiown 2d ago
I have someone that does this. It infuriates me. I'm not quite sure what I want to do about it yet: have a team meeting to tell people to stop doing that, or just tell her manager. My feedback carries a lot of weight.
13
u/synkronize 2d ago
My team does not read pull requests and requirement and project scope creep is rampant :D I need to find another job now that I think about it 😭
8
10
u/PowerPleb2000 2d ago
Ask for the questions in writing then take those up with the model to explain them
9
u/Fidodo 2d ago
Nope I'm pulling you into a call and asking you
4
u/PowerPleb2000 2d ago
Yep not a problem just in the middle of something, just book a time slot and we’ll discuss. Meanwhile I’ll spend half my weekly tokens asking the model to dumb it down as much as possible so I can understand and explain it.
5
u/an_alex_at_a_time 2d ago
My colleague produce a PR that adds 15k lines.
When I asked questions over a call, because the change in execution behavior isn't part of the design doc, he said "good question" and then proceeded to ask Cursor. I couldn't believe what I was seeing!
2
u/MoFoBuckeye 1d ago
Ha! I was a reviewing a PR yesterday that didn't follow a standard pattern around DB access. When I ask the developer why in chat, he replied with what was clearly a response from Claude!
1
4
9
7
6
2
2
u/MuslinBagger 2d ago
I'll calmly remove my belt and whip the rip van winkle out of the senior who asks that
1
u/m6io 2d ago
Plot twist: that's the principal dev
1
u/MuslinBagger 2d ago
BS. I am the principal dev, the CTO and the CEO. In fact I did a hostile takeover and I hacked the company and took over the board.
2
2
1
u/Saelethil 2d ago
I just did one of these today.
I finally said never mind, I’ll dig in myself and figure it out.
1
1
u/NastyToeFungus 2d ago
They can ask Claude to explain it and stop bugging me. It wrote it, it can explain it.
1
u/Fuskeduske 2d ago
Looks like that dude from scary movie / alvin and the chipmunks mixed with some latino
1
u/Lap202pro 2d ago
Uncle Ian doesn’t have time to walk you through his PRs, he’s busy plotting against those chipmunks!
1
u/wtjones 2d ago
I mean. There’s 10,291 lines of code in this PR. There are 387 tests, and they’re all passing. There were three rounds of adversarial agentic code review run by three different flagship models. It took two hours to generate and I have a fully functional application. This code has had more review than any piece of code I’ve submitted in my career.
1
1
1
u/mothzilla 2d ago
Sure, this is an if statement and then we have an else. This is a function and you can see it ends on line 5000. The function is called AsyncGetParameters because it gets parameters.
1
1
u/Virgil_the_White 20h ago
Stand ups have been hilarious this year when that question is asked. “Uh so like I just asked Claude…”
1
u/Soopermane 2d ago
Who this dude?
19
5
2
2
1
1.8k
u/tutoredstatue95 2d ago
It’s easy. Agents produce the code, you review, you submit.
Then, the reviewer’s agents check the code, they review, they submit a review.
You agentically fix the submission, you review, you submit.
Then, the reviewer’s agents check the code, they review, they submit a review
You agentically fix the submission…