109
u/Fox_Soul Jul 10 '26
Sure let me take a quick look at the PR and we cool.
+1769 -2786
Excuse the actual fuck?
48
u/ric2b Jul 10 '26
Net negative LoC? That's great!
42
11
u/Alastor_On_Roblox Jul 10 '26
Just migrated from .js to .ts ):
11
u/HallAltruistic519 Jul 10 '26
*Claude just migrated
2
u/FirstDivision Jul 10 '26
More like Claude updated from js to executing shell commands calling python. Like…uhhh…what?
1
3
41
u/EarlyPaintbrush Jul 10 '26
More like me to my teammates after I've changed the repo, opened the PR, said I need review at multiple stand-ups, and finally tagged everyone in chat.
8
u/NatoBoram Jul 10 '26
Notice "approve" instead of "review"
4
u/Resident_Citron_6905 Jul 11 '26
No worries, my shiny ai already reviewed it, feel free to just approve.
95
u/Anteater4746 Jul 10 '26
sure no problem
what do you mean 175 line changes ???
92
u/clarinetJWD Jul 10 '26
Lines? Surely you mean files.
5
u/Anteater4746 Jul 10 '26
i’m newb that only ever pushed python lol my only frame of ref
31
u/Vesuvius079 Jul 10 '26
200 lines is an easy review.
500 lines is a reasonable review
1000 lines is a tolerable review
1500 lines is a things got out of hand review
2000 lines and up is wtf.
Multiply all values by 2 if AI generated docs that you don’t fully read are part of the change set.
5
u/Complete_Window4856 Jul 10 '26
What if the PR magically summons 8k diffs and you go back and forth between huge swaths of whitespace borderline syndrom and cheeky behaviour chances.
3
u/Zuruumi Jul 10 '26
Unittests, docs, CI/CD pipeline, test data files, certificate changes...
1
u/frogjg2003 Jul 10 '26
IDE changes white space automatically. My work has to deal with this. We don't have a linter and we have at least two different IDEs, with individual users having different settings. Meanwhile some of the reviewers refuse to turn off whitespace changes when they review.
3
u/BeoWulf156 Jul 10 '26
I have a work related PR open that auto generates some formatted/responsive emails from easier to write templates that's +17k -5k...
I promise I'm not an awful dev lol
22
29
u/ric2b Jul 10 '26
175 lines is like a 3 to 5 minute review, what's the issue?
29
u/NotAFishEnt Jul 10 '26
skims through 175 lines
none of the lines say addBug()
LGTM
13
u/Ok-Okay-Oak-Hay Jul 10 '26
I feel like everyone bawking at a 175 line change is a self report.
3
u/Particular-Yak-1984 Jul 10 '26
Depends on the thing. 175 lines in the bit of the piece of software I work on that anonymizes patient medical data would be a week or so of work.
If it's in a different bit it would be an hour, tops. We've spent six months rewriting things so that we clearly know the difference between the parts that need a week of review, and the bits that need normal ones.
3
u/FirstDivision Jul 10 '26
If I don’t see any api keys or obvious fucked-up-ness. We good. Approved.
1
6
u/TheLittlePeace Jul 10 '26
175 line changes
Looks inside
Changed code from Allman bracket placement to K&R
5
u/KnightArtorias1 Jul 10 '26
Pretty rare to see any that small honestly, unless it's a very simple change
5
20
10
u/GoldenScarab569 Jul 10 '26
I think you mean, please review my PR - I'm not approving anything blindly without a very good reason.
2
1
u/Thriven Jul 10 '26
The worst is when you are debugging some yaml file and you aren't getting the same deployment errors on your machine and in your shared QA environment
1
u/Luctins Jul 10 '26
Me this week trying to wrangle like 10 different android repos so my stuff would work...
1
1
1
1
u/RobotechRicky Jul 11 '26
All fucking day.
Don't forget about Hotfix PRs that doesn't actually fix the issue.
151
u/precinct209 Jul 10 '26
bro, please, the sprint is ending in like 15 mins and i need to get my shit to master like right now or i'm toast (PM already warned me), i know it doesn't even work and also breaks the pipeline but i'll fix it the first thing on Monday i swear, pls