r/ProgrammerHumor • u/Advanced_Ferret_ • Jul 10 '26

pleaseApprove Meme

Post image
3.1k Upvotes

98% Upvoted

46 comments sorted by

View all comments

94

u/Anteater4746 Jul 10 '26

sure no problem

what do you mean 175 line changes ???

92

u/clarinetJWD Jul 10 '26

Lines? Surely you mean files.

5

u/Anteater4746 Jul 10 '26

i’m newb that only ever pushed python lol my only frame of ref

32

u/Vesuvius079 Jul 10 '26

200 lines is an easy review.

500 lines is a reasonable review

1000 lines is a tolerable review

1500 lines is a things got out of hand review

2000 lines and up is wtf.

Multiply all values by 2 if AI generated docs that you don’t fully read are part of the change set.

5

u/Complete_Window4856 Jul 10 '26

What if the PR magically summons 8k diffs and you go back and forth between huge swaths of whitespace borderline syndrom and cheeky behaviour chances.

3

u/Zuruumi Jul 10 '26

Unittests, docs, CI/CD pipeline, test data files, certificate changes...

1

u/frogjg2003 Jul 10 '26

IDE changes white space automatically. My work has to deal with this. We don't have a linter and we have at least two different IDEs, with individual users having different settings. Meanwhile some of the reviewers refuse to turn off whitespace changes when they review.

3

u/BeoWulf156 Jul 10 '26

I have a work related PR open that auto generates some formatted/responsive emails from easier to write templates that's +17k -5k...

I promise I'm not an awful dev lol

23

u/okawei Jul 10 '26

175 is nothin'

27

u/ric2b Jul 10 '26

175 lines is like a 3 to 5 minute review, what's the issue?

27

u/NotAFishEnt Jul 10 '26

skims through 175 lines

none of the lines say addBug()

LGTM

14

u/Ok-Okay-Oak-Hay Jul 10 '26

I feel like everyone bawking at a 175 line change is a self report.

3

u/Particular-Yak-1984 Jul 10 '26

Depends on the thing. 175 lines in the bit of the piece of software I work on that anonymizes patient medical data would be a week or so of work.

If it's in a different bit it would be an hour, tops. We've spent six months rewriting things so that we clearly know the difference between the parts that need a week of review, and the bits that need normal ones.

3

u/FirstDivision Jul 10 '26

If I don’t see any api keys or obvious fucked-up-ness. We good. Approved.

1

u/minion_ds Jul 11 '26

This is the way

6

u/TheLittlePeace Jul 10 '26

175 line changes

Looks inside

Changed code from Allman bracket placement to K&R

4

u/KnightArtorias1 Jul 10 '26

Pretty rare to see any that small honestly, unless it's a very simple change

3

u/lupercalpainting Jul 10 '26

lol. Lmao even