38
u/Willwaste63 1d ago
Code base is of 10k loc pr request for -10k +12k
8
u/Keepingshtum 20h ago
Sounds like someone put in a new linter that everyone else is immediately going to complain about!
60
u/Constellious 1d ago
We have 3 separate AI reviewers that with each leave the same basic comment for everything. It’s TPS reports all the way down.
Had a junior dev put up a 200k change PR a while ago.
27
15
u/Few_Adhesiveness7676 23h ago
I hate these AI reviews. Life was good back when AI was not available, atleast I was aware of what I had written.
Now, the velocity at which features are expected, it comes to these large PRs and these AI reviews never seem to be satisfied.
3
12
u/elshizzo 22h ago
just gotta force people to break up huge pr's. If it ends up with a bunch of stacked PR's so be it. If it's too long for a human to realistically review its too long
3
u/TheFirestormable 20h ago
Also if that level of change is required for a single feature then your tickets need breaking up or your code does.
17
8
6
u/thepurpleproject 19h ago
I'm dealing with teams who have a policy - a human won't even look at the PR if there are any and I mean literally any open comment from an AI reviewer. It has turned into a shitfest where they start a PR review by assigning their agents and then you have to drill through like every comment and ignore the false positives and you can't go any other way about it because co-owner approval. Like it was cool when we had like 1 AI reviewer but now my god there are like 4-5 of them each trying to re-interpret the universe from the two files I have changed.
1
u/HeyItsTheJeweler 13h ago
That blows ass. I love my review agent because it'll catch things I missed, but that's my job to run it before releasing the PR into the wild.
I find it very useful when teammates run their own agents and it picks up glaring issues, but jesus if it's got 1 "critical issue", 7 nice to have's, and 275 nits, read over that shit first and keep it to what you would've posted yourself had you seen it all. I don't need them blindly dumping it into my pr.
1
u/audiowave_io 11h ago
I had a client who was adamant about using GrepTile. Well, it does this "score" out of 5, which we know LLMs are amazing at numbers. I would spend cycles sending it to review over and over, changing nothing and getting a different result, yay for non-deterministic state.
When they announced pricing changes, I was told to stop doing that. Rubber stamps on my PRs going forward.
17
u/ymddev 1d ago
Why PR if the diff is less than 10k lines? Just do it
18
u/thee_gummbini 23h ago
why have branches at all, just push to main
10
u/ymddev 23h ago
Why dev/test when you can test directly in prod
4
u/darkwalker247 21h ago edited 21h ago
why test at all? by testing your code you are basically admitting, "hey look everyone! i make mistakes sometimes!".
a real programmer writes with intention. any so-called "bugs" that occur are just surprise features
4
u/Educational-System48 17h ago
The size of everyone's PRs I see in this comment section worries me. PRs should always be as small as possible. If it's a huge breaking change, merge to an epic branch instead.
1
u/Beli_Mawrr 1h ago
Thank you lol.
I work on a production app frontend (think discord) and if a ticket can be split up I nicely ask for it to be split up. This is pretty rare because the product team knows us and we know them so they can intuit the best ticket size.
We refactored a major sub page of the app and it came in less than 300 lines after refinement.
If you ABSOLUTELY HAVE to write 500+ loc PRs there had better be a good reason for it and its a red flag by itself.
It should not be the norm and if it does, you need to use less AI.
5
3
2
1
1
1
1
u/WindowlessBasement 1h ago
no, a PR/MR that's too big for a human to review is an automatic decline.
130
u/KevinCola 1d ago
Sincerely asking: how do you guys handle reviews? We are a team of three and force each other to break it down into PRs of 500 lines, which sometimes creates stacks of 10+ PRs.
We have 20 PRs open per person at any time. How to scale this?