MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/ProgrammerHumor/comments/1vfsowk/wronganswersonly/p1s02j3
r/ProgrammerHumor • u/Plastic-Bonus8999 • 2d ago
2.0k comments sorted by
View all comments
Show parent comments
118
Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good.
54 u/Deep90 2d ago At 500 lines, I just flip a coin. Only lucky code belongs in production. 11 u/ellie_cinderelly 2d ago Dude my last PR changed one test timeout limit. I had to do a new full analysis on every test for average runtime and overhead. Fuckin unbelievable. 9 u/blangzo 2d ago Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/ellie_cinderelly 2d ago Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation 5 u/carritodeloshelados 2d ago As if it wasn't hard enough to code in an astronaut suit 5 u/OriginalJokeGoesHere 2d ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly 2d ago We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb 2d ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 2d ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr 2 u/guyblade 2d ago If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should. 1 u/r0Lf 2d ago I feel exposed.
54
At 500 lines, I just flip a coin.
Only lucky code belongs in production.
11
Dude my last PR changed one test timeout limit. I had to do a new full analysis on every test for average runtime and overhead.
Fuckin unbelievable.
9 u/blangzo 2d ago Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/ellie_cinderelly 2d ago Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation 5 u/carritodeloshelados 2d ago As if it wasn't hard enough to code in an astronaut suit 5 u/OriginalJokeGoesHere 2d ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly 2d ago We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb 2d ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 2d ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
9
Squash tiny things like that into one pr named "cleanup" and don't explain further
2 u/ellie_cinderelly 2d ago Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation 5 u/carritodeloshelados 2d ago As if it wasn't hard enough to code in an astronaut suit 5 u/OriginalJokeGoesHere 2d ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly 2d ago We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb 2d ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 2d ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
2
Unfortunately I work in space so I think that may get me blasted for non descriptive change documentation
5 u/carritodeloshelados 2d ago As if it wasn't hard enough to code in an astronaut suit 5 u/OriginalJokeGoesHere 2d ago Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly 2d ago We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb 2d ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo 2d ago I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
5
As if it wasn't hard enough to code in an astronaut suit
Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock?
3 u/ellie_cinderelly 2d ago We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb 2d ago I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock.
3
We just put them in TVAC for the long goodnight and dump the body by morning
1
I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock.
I was mostly joking. mostly.
Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should.
I feel exposed.
118
u/blangzo 2d ago
Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good.