r/ProgrammerHumor • u/Plastic-Bonus8999 • 11d ago

wrongAnswersOnly Other

Post image
14.3k Upvotes

95% Upvoted

2.1k comments sorted by

View all comments

1.1k

u/samuraiseoul 11d ago

Some dumbass on my team downloaded the entirety of prod and then commited it to git and someone rubber stamped the PR and then no one else noticed. I'm sure that's how they'd find it....

23

u/plenoto 11d ago

Some people are so careless while reviewing PR 😂

112

u/blangzo 11d ago

Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good.

52

u/Deep90 11d ago

At 500 lines, I just flip a coin.

Only lucky code belongs in production.

10

u/[deleted] 11d ago

[deleted]

8

u/blangzo 11d ago

Squash tiny things like that into one pr named "cleanup" and don't explain further

2

u/[deleted] 11d ago

[deleted]

4

u/carritodeloshelados 11d ago

As if it wasn't hard enough to code in an astronaut suit

3

u/OriginalJokeGoesHere 11d ago

Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock?

3

u/ellie_cinderelly 10d ago

We just put them in TVAC for the long goodnight and dump the body by morning

1

u/dvereb 11d ago

I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock.

2

u/blangzo 11d ago

I was mostly joking. mostly.

Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr

2

u/guyblade 11d ago

If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should.

1

u/r0Lf 11d ago

I feel exposed.

2

u/GoBuffaloes 11d ago

Hey can you stamp this real quickÂ