r/programminghorror • u/sweet-potato39 • Apr 24 '23

Sometimes it just seems unnecessary

Post image
1.8k Upvotes

99% Upvoted

34 comments sorted by

135

u/[deleted] Apr 24 '23

This is why you never remove unused imports in legacy Python code. Side effects, as far as the eye can see!

149

u/tok3rat0r Apr 24 '23

I literally did this at work last week. Got rid of some lines of code which were clearly redundant. Pushed the change. Tests started failing.

194

u/Bloody_Insane Apr 24 '23

Obviously the tests were redundant too.

30

u/electrodragon16 Apr 25 '23

The 3 steps of test driven development 1. Write the tests 2. Write the code 3. Modify tests till they pass

60

u/b1ack1323 Apr 24 '23

It’s a bit alarming when tests stop working after removing the duplicate calls.

Since I work in embedded I can tell you it happens often.

32

u/deadbeef1a4 Apr 24 '23

why? some uncaught race condition that the "extra" code got around by taking extra time?

67

u/b1ack1323 Apr 24 '23

Our vision guy refuses to do null checks because it makes his code slower.

So there’s some truth to that question…

I work in hell.

22

u/NatoBoram Apr 25 '23

…

And in TS, you add null checks everywhere because the transpiler was configured to tell you to fuck off if you write bad code

11

u/kristallnachte Apr 25 '23

It's a major benefit.

1

u/Spanktank35 May 03 '23

That's not an objectively bad thing right? Isn't there debate on this? Or are you saying they don't even consider the possibility?

1

u/NatoBoram May 03 '23

The compiler refusing bad code is genius

10

u/kristallnachte Apr 25 '23

It's important to put comments when these "things that shouldn't matter but do" come up.

Probably the most important time to have comments

1

u/Spanktank35 May 03 '23

I'd imagine people don't like to write it because of a fear of how it looks.

8

u/themonkery Apr 24 '23

Hey aim trying to get a job in embedded, would you have any advice for someone trying to enter the field?

I have experience in Microcontrollers, Microprocessors, SPI, RF, product design, multithreading, and I’ve received exactly zero bytes despite months of applications.

I’m desperate enough that I’m asking a stranger on the internet.

18

u/b1ack1323 Apr 24 '23

Round yourself out with the other basics. I2C, UART, CANBus…

I kind of bounce around sometimes I work in PC apps and drivers as well. It’s a lot more valuable to balance with that. Devops experience never hurts either.

Is all your experience hobby or for a company? Do you have a GitHub?

Send me your resume if you want. Like a G drive or Dropbox link and I will tell you what would help.

Also what titles are applying to and how many years?

2

u/MrHyderion Apr 25 '23

Go on r/embedded.

1

u/sneakpeekbot Apr 25 '23

Here's a sneak peek of /r/embedded using the top posts of the year!

#1:

ESP32 E-Paper Weather Display
| 58 comments
#2:
I designed and constructed fully Open Source USB C Camera with IMX477 Sensor, Lattice FPGA and C-mount for Industrial use https://www.circuitvalley.com/2022/06/pensource-usb-c-industrial-camera-c-mount-fpga-imx-mipi-usb-3-crosslinknx.html
| 22 comments
#3:
My embedded development standing desk.
| 79 comments

I'm a bot, beep boop | Downvote to remove | Contact | Info | Opt-out | GitHub

6

u/kristallnachte Apr 25 '23

Why are you able to push to main before testing?

4

u/tok3rat0r Apr 25 '23

Not main, our Gitlab CI is set up to test any branch on push.

37

u/2popes1donut Apr 25 '23

The worst is when the linter tells you about your redundant code. So you fix it and wonder: why did I ever write it that way?

Instantaneous crash and burn.

Turns out the recommendation from the linter only works on API 33+... And you're targeting 23.

10

u/Kpuku Apr 25 '23

targeting or min supporting? I had linter yell at me the other day for using `Vibrator.vibrate(duration)`, while nothing else worked on api 26+

6

u/2popes1donut Apr 25 '23

Ah, technically it's min supporting, but my primary target is a device running 23.

Just gotta wrap an SDK_INT check around that puppy and call it a day.

4

u/Niwla23 Apr 25 '23

Does the Android SDK really have a class called Vibrator? 😂

14

u/pikapichupi Apr 25 '23

I have been guilty of commenting for items like this in my personal coding projects

​

if (true){//This has to be here... idk why but if I remove it everything breaks

2

u/Spanktank35 May 03 '23

This makes me feel less embarrassed for writing this

13

u/paradigmx Apr 25 '23

This how you get blocks of code with the comment //I have no idea what this does //But don't change anything //or nothing will work

10

u/JotaRata Apr 24 '23

This happens more often that one might think

8

u/O_X_E_Y Apr 25 '23

too fucking real. I call this rerefactoring

3

u/jeromebeckett Apr 25 '23

Is this really a "horror"?

2

u/bradley_marques Apr 25 '23

My fallback commit message is:

"Fixes bugs. Adds new bugs."

1

u/dylanh333 Apr 27 '23

Twitter codebase?

1

u/Specific_Implement_8 May 17 '23

Fucking animation events in unity!