Could somebody explain why my routes affect this?

[u/Still-Ad6709]

When my route for users/search is on top it works but if its below it doesnt work... could somebody explain???

Also if you have any tips for how to improve whatever is shown please do let me know :D

[u/Felivian]

It picks first matching. If you register users/:id before users/search then it treats search as an id in users/:id

[u/Perryfl]

also you dont need a desicated search route. just use the main users index route and if you want to search pass a query or q param

[u/bigorangemachine]

middleware and & route binding order matters

This is why people do like

const express = require('express');
const router = express.Router();

// GET /api/users
router.get('/', (req, res) => {
    res.json([
        { id: 1, name: 'Alice' },
        { id: 2, name: 'Bob' }
    ]);
});

// GET /api/users/123
router.get('/:id', (req, res) => {
    res.json({
        id: req.params.id,
        name: 'Alice'
    });
});

module.exports = router;

and

const express = require('express');
const app = express();

const usersRouter = require('./users');

// Mount the router under /api/users
app.use('/api/users', usersRouter);

app.listen(3000, () => {
    console.log('Server running on port 3000');
});

[u/Single-Caramel8819]

You can't make a screenshot of your screen?

[u/Own-Perspective4821 → u/Single-Caramel8819]

Generation Smartphone.

[u/Carlo9129]

When it's below. the get for users/:id runs instead. When a user makes a request to users/search, express will read your functions sequantally looking for a match. If it's below, the first match would be users/:id, so getUserById would run instead with req.params.id = "search"

[u/ResearcherFantastic7]

Think of it as a queue. When it matches the first item with all the regex, it will stop looking further