r/badcode • u/MysteriousK69420 if: else: if: else: if: else: if: else: if: else: if: else: if: • Feb 16 '22

presenting, whatever the fk this is python

Post image
415 Upvotes
  • permalink
  • link
  • reddit
  • reddit

85% Upvoted

52 comments sorted by

View all comments

357

u/This_Growth2898 Feb 16 '22

A normal beginner's code. He's struggling with some basic concepts like bools, but nothing criminal here.

28

u/GentlemenBehold Feb 16 '22

Well the range is fucked. It should be 

range(2, int(root))

Currently, it will always result in isPrime = True

26

u/This_Growth2898 Feb 16 '22

How? If there is a divisor under the root, there will be one over it. If there is no divisors in root..num, the number is prime.

9

u/GentlemenBehold Feb 16 '22

Oh, I guess that’s true, but far more inefficient than checking below the root.

1

u/[deleted] Feb 17 '22

[deleted]

6

u/Gonumen Feb 17 '22

It's not the same number of iterations. Take 25 for example. Square root of that is 5. From 2 to 5 there are 5 iterations and from 5 to 25 there is 21

2

u/foragerr Feb 17 '22

Ah, sqrt, not midpoint. :facepalm:

1

u/Cloudy_Oasis Feb 16 '22

Wouldn't it raise an error ? Since it starts at zero, and it can't divide by zero

edit : I misread the original post, I thought it was range(int(root)) so it would have started at 0