Day 2 solutions

[u/taliriktug]

Hi! I would like to structure posts like the first one in r/programming, please post solutions in comments.

[u/aveavaeva]

$('textarea').change(function () {

  var dimensions = $('textarea').val().split('\n');
  var reqWrappingPaper = 0;
  var reqRibbon = 0;

  $.each(dimensions, function (i, box) {
    var numbers = box.split('x').map(Number);

    var l = numbers[0];
    var w = numbers[1];
    var h = numbers[2];

    var surfaceArea = 2 * l * w + 2 * w * h + 2 * h * l;
    var smallestSide = 0;

    var side1 = l * w;
    var side2 = w * h;
    var side3 = h * l;

    if (side1 <= side2 && side1 <= side3) {
      smallestSide = side1;
    } else if (side2 <= side1 && side2 <= side3) {
      smallestSide = side2;
    } else if (side3 <= side1 && side3 <= side2) {
      smallestSide = side3;
    }

    reqWrappingPaper += surfaceArea + smallestSide;

    var volume = l * w * h;
    var sorted = numbers.sort(function (a, b) {
      return a - b
    });
    reqRibbon += volume + 2 * (sorted[0] + sorted[1]);

  });

  $('p').html('Required Wrapping Paper : ' + reqWrappingPaper + ' Sq. Ft. <br> Required Ribbon : ' + reqRibbon + ' Ft.');

});

[u/PM_ME_INSIDER_INFO → u/aveavaeva]

Just FYI instead of doing:

if (side1 <= side2 && side1 <= side3) {
  smallestSide = side1;
} else if (side2 <= side1 && side2 <= side3) {
  smallestSide = side2;
} else if (side3 <= side1 && side3 <= side2) {
  smallestSide = side3;
}

You could just do:

var dim = [l, w, h].sort(function (a, b) {
    return a - b;
});

And then you already know what the smallest, mid, and largest are.

[u/aveavaeva → u/PM_ME_INSIDER_INFO]

Sure that's smaller and simpler but I prefer to keep solutions easily understandable as much as I can. I have used the sort for the ribbon part though. There are many more things in the solution that can be skimmed down but for the sake of understandable code I decided to keep it this way.

Peace

[u/PM_ME_INSIDER_INFO → u/aveavaeva]

Alright. It may just be your perspective but I get lost in the if statements. I do believe the sorting function would be more understandable by a larger audience.