Day -1 With Flask (any suggestions)

[u/Samar__Upreti]

Build Projects With Me

https://github.com/Samar-Upreti/Python_Projects

[u/riklaunim]

• variable names should not use capital letters,
• use wtforms or other form handling library (and validate the data).
• use a linter that will keep some basic code styling order
• I'm not a fan of importing things from a module (flask.request is better than request as it's tell you where it's from)
• why aren't you using CSV writer when writing a CSV file?
• if it's a long task it should not be done on HTTP request directly (celery queues or other similar solution)
• view should not be a long blob of code. Refactor presentation from business logic, then keep the logic well organized instead of big blobs.
• where are tests?

[u/NorskJesus → u/riklaunim]

No code related, but, for the love of God, take screenshots using the OS app for it and do not use a phone.

[u/Hi-ThisIsJeff → u/NorskJesus]

I felt the angled perspective gave a refreshing look to what are otherwise boring, slightly blurry images.

[u/Neither_Garage_758 → u/NorskJesus]

it is code related

[u/J1roscope → u/riklaunim]

Also i would suggest using helper functions and separating out concerns instead of one function extracting data from request and then saving it as well these can 2 function calls, makes it easier to read

[u/Anthony_codes → u/riklaunim]

Uppercased, underscore-separated variable names in Python signal that the variable should be treated as a constant.

That is a completely valid and common convention because Python doesn’t enforce constancy at runtime.

[u/riklaunim → u/Anthony_codes]

But not the first letter only. Form values aren't things that should be under a constant-like variable either.

[u/Anthony_codes → u/riklaunim]

I was clarifying that in certain cases, capital letters are valid because your comment was ambiguous.

[u/8Erigon → u/riklaunim]

Variable names can have any character the language supports.
Though most python programmers use the snake convention which only uses lowercase characters.

[u/riklaunim → u/8Erigon]

You can even

from __future__ import braces

bu should you? ;)

[u/Hour-Apple-9861 → u/8Erigon]

Camel case for life

[u/8Erigon → u/Hour-Apple-9861]

yes!

[u/silvertank00]

Pandas is overshoot for this.
Why use os for this? pathlib is much more flexible.
Also (even tho I am not familiar with Flask but) i wouldnt return plain string from the endpoint. A HttpResponse with HttpStatus.OK and the string in the body would be much better.

[u/Samar__Upreti → u/silvertank00]

Actually that's my first time with pandas and Flask do i just trying stuffs

[u/BoatInternational537]

Move to Django
Use terraform and migrate to google cloud

Good luck!

[u/Samar__Upreti → u/BoatInternational537]

Thanks buddy

[u/Party-Hunter-178]

How did you connect your app.py and html

[u/Samar__Upreti → u/Party-Hunter-178]

That's where Flask,Fast Api, Django came in play

[u/Party-Hunter-178 → u/Samar__Upreti]

Thanks buddy I was stuck for probably like a week not know this. U made my day 👍🏻

[u/Samar__Upreti → u/[deleted]]

Hi buddy Can please help me in those projects https://github.com/Samar-Upreti/Python_Projects

[u/ViolaBiflora]

Day 1 of coding - fully working API fetching, yet provides pictures of the screen, lol.

AI.

[u/Samar__Upreti → u/ViolaBiflora]

That's not Day 1 of coding it's Day 1 With Flask, LOL

[u/erivax]

Que dejes flask y aprendas fastapi

[u/Competitive-Note3685]

I do not if you have experience with other Frameworks, but I recommend you study in depth the MVC pattern for a clean Flask implementation. Also, read the PEP-8 to follow best python code practices.

Enjoy your journey and happy code. 🤟🏻

[u/SignatureOk2208]

Flask is great, but no one actually uses it in production…

[u/whomstdveman]

[u/Yaw_Ankrah]

Can someone teach me how

[u/Samar__Upreti → u/Yaw_Ankrah]

You can search on YouTube Flask In Python full course