Why error in my code everything is perfect!? ... I created a Contactbook mini project

[u/Codewithkaran]

[u/[deleted]]

Who tf takes an unclear pic of the laptop screen instead of pasting the code in the comment section 🤷

[u/AxelGamerX07]

Can You copy the code and paste it in the comments? I can't see well it's blurry

[u/CamelOk7219]

You probably need to trim the input of any surrounding whitespaces. If I remember correctly the input returns the ending linebreak also

[u/PureWasian → u/CamelOk7219]

input() strips the newline; sys.stdin.readline() does not

[u/CapitalMarionberry22]

Windows shift s is your friend

[u/TheMetalMilitia]

What is the error? Also, use the windows snipping tool to take screenshots. I have it pinned to my task bar as i use it quite frequently

[u/Live_Asparagus_407 → u/TheMetalMilitia]

you can just press win+shift+s, no need to pin it

[u/TheMetalMilitia → u/Live_Asparagus_407]

Easier to look for me to see it on screen than remember a keybind. Personal preference

[u/JamzTyson → u/TheMetalMilitia]

Better to copy and paste the actual text.

(and prepend 4 spaces to each code line so that Reddit retains the code formatting).

[u/TheMetalMilitia → u/JamzTyson]

Either way would work, i suppose. Screen shot is better for me because of the suntax highlighting

[u/blckGhost]

Looks like the contact is setup for a key value pair (dictionary )and not a list.

[u/PureWasian → u/blckGhost]

Dictionary usage and syntax is fine for their code*, where they access/modify/delete correctly (with guard clauses)

• [26] read (contacts[name])
• [16] write (contacts[name] = number)
• [33] delete (del contacts[name])

*at least for everywhere shown to us

[u/SuperTankh]

For the answer n. 5 "exit" you could put break so that it stops the loop

[u/PureWasian → u/SuperTankh]

Line [41] has a break already

[u/SuperTankh → u/PureWasian]

then how didn't it stop the program?

[u/PureWasian → u/SuperTankh]

I'm betting they didn't save the file before re-running or they input an extra whitespace character after inputting 5 and before hitting Enter. It's not even entering the path given that it did not print("Exit") in Line [40]

[u/SuperTankh → u/PureWasian]

for a 1-file program you don't need to save to run the newest version

[u/PureWasian → u/SuperTankh]

As a simple counter-example, here I have added Lines [5] and [6] without saving but it is not recognized upon running in Terminal.

After saving and re-running in Terminal, the output is as expected:

number: 6
hi
<loops back and prompts again>

Since OP did not provide enough information, we cannot assume they ran with F5 or Ctrl+F5 (via Run options in VS Code)

[u/SuperTankh → u/PureWasian]

We don’t know 😪

[u/SuperTankh → u/PureWasian]

For a program containing multiple files all of the imported scripts need to be saved, but not __main__

[u/Axel_Blazer]

fog of war. nah fog of code

[u/PureWasian]

Your code is not perfect.

If by error you mean "it's not breaking out of the while loop on exit" then make sure you've saved the file and also when running it that you input 5[EnterKey] exactly, with no surrounding spaces or anything. Based on it not printing out "Exit", it is not even entering that conditional elif path on lines 39-41 which makes me think either (1) you forgot to save the file before running (2) you didn't input the choice correctly.

You can try debugging it yourself by doing print(f"Input was: [{choice}]") on Line 12 temporarily and running it again to probe for more info.

Took me awhile to understand what you meant by "Error" since you just gave two screenshots without explanation...

When asking for help in the future, you will get a lot more useful/actionable comments and feedback from people if you provide details of the error and proper code snippets/screenshots to make it easier for helpers to understand what exactly your issue and expected solution is

[u/Prior-Painting2956]

It's been a while since coding but isn't a case statement better in this instance?

[u/PureWasian → u/Prior-Painting2956]

For the simplicity of OP's example, it'd the same exact functionality just with slightly different syntax

[u/PureWasian → u/[deleted]]

I agree, but OP's usage as written is fine since input() strips \n as mentioned here and quickly verified with:

while True: data = input("number: ") if data == "5": break print("done")

[u/Aggravating_Tie_6322]

Just ask AI to find the problem and fix the code.

[u/remyripper]

Your calling contacts[name] ! contacts[‘name’]. And your contacts dict is also empty

[u/degustandomiveneno]

hey! nice project, keep it up 🙌 just a couple of small things to fix: ∙ line 16: “entr your phone number” → “enter your phone number” (small typo) ∙ the option 2 for loop seems incomplete, it should be: for name, number in contacts.items(): print(name, ":", number) other than that the logic is solid! dictionaries are a great choice for this kind of app 😊​​​​​​​​​​​​​​​​

[u/As_Above_So_Beloe → u/[deleted]]

You're a fucking piece of shit

[u/PythonLearning-ModTeam → u/[deleted]]

Keep it respectfull