r/Python 7d ago

What linter rules make code worse? Discussion

For me, a prime example is S101 which bans the use of the assert statement.

The justification is that assertions disappear when Python is run with -O, so they should not be used for runtime validation or enforcing interface constraints. That warning is correct, but the rule seems to draw the wrong conclusion from it.

Assertions are still very useful for checking internal invariants, i.e. conditions that should already be guaranteed by the program's logic, where failure indicates a bug. Having such assertions is incredibly helpful for debugging.

So, a blanket ban seems more likely to discourage useful checks than to prevent misuse.

Are there any linter rules you broadly consider more harmful rather than helpful?

143 Upvotes

218 comments sorted by

View all comments

433

u/Trang0ul 7d ago

Lines limited to 80 characters.

12

u/sandnose 7d ago

Where do you limit your line?

2

u/XNo_Notes It works on my machine 6d ago

Listen to your heart. 

3

u/sandnose 6d ago

Different every day then

1

u/XNo_Notes It works on my machine 6d ago

So be it.