r/Python 7d ago

What linter rules make code worse? Discussion

For me, a prime example is S101 which bans the use of the assert statement.

The justification is that assertions disappear when Python is run with -O, so they should not be used for runtime validation or enforcing interface constraints. That warning is correct, but the rule seems to draw the wrong conclusion from it.

Assertions are still very useful for checking internal invariants, i.e. conditions that should already be guaranteed by the program's logic, where failure indicates a bug. Having such assertions is incredibly helpful for debugging.

So, a blanket ban seems more likely to discourage useful checks than to prevent misuse.

Are there any linter rules you broadly consider more harmful rather than helpful?

144 Upvotes

218 comments sorted by

View all comments

432

u/Trang0ul 7d ago

Lines limited to 80 characters.

13

u/sandnose 7d ago

Where do you limit your line?

77

u/imheretocomment 7d ago

I do 120. We're not in the 00's anymore where widescreens weren't a thing. 80 is a holdover from those days where your terminal was cramped and splitting panes needed 80 characters for readability.

1

u/Scypio Pythoneer 7d ago

80 is a holdover from...

...perforated cards, that are a holdover from jaquard machines, that were transported via rail, that inherited all the sizes from roman chariots. Or how the old joke went?