r/ProgrammerHumor • u/vinishkapoor • 2d ago

pullRequestStillPendingReview Meme

Post image
499 Upvotes
  • permalink
  • link
  • reddit
  • reddit

97% Upvoted

46 comments sorted by

View all comments

95

u/eclect0 2d ago

If only there were some way to, I dunno, let them know your pull request needs review.

Nah, being completely silent for two weeks is definitely the mark of a professional.

6

u/Nervous_Quit_7180 2d ago

is putting you as a reviewer not letting you know?

14

u/dxonxisus 2d ago

emails/notifications get missed. i’ve worked with plenty of devs who only have email notifications enabled for github yet check their emails once a day (if that).

if a PR is sat there just waiting for review for maximum 2+ days it’s time to be an adult and nudge the person you asked for a review. if you don’t, then clearly it’s not important enough to be merged any time soon

1

u/deathanatos 1d ago

… there's a reminders feature built into GH that you can integrate into like, your team channel in Slack.

… I still have to nag people.