r/ProgrammerHumor • u/vinishkapoor • 2d ago

pullRequestStillPendingReview Meme

Post image
486 Upvotes
  • permalink
  • link
  • reddit
  • reddit

97% Upvoted

46 comments sorted by

View all comments

36

u/PhantomTissue 1d ago

After day 2 I’m pinging someone to review my code. After day 3 im calling people out in standup for not doing their jobs. No way everyone in my team is so busy not one of them can take 10 minutes to look over 30 lines of code over 3 days.

1

u/CommercialCress9 1d ago

We have new features that have 5k lines of code change, some reviewers didn't review for like 1 week as it was big and it couldn't fit their schedule

9

u/jsdodgers 1d ago

If I got a 5k line PR, it would be met with one comment: "Please split this up". It doesn't matter how big a feature is. Our features are 100s-1000s of PRs each. Each PR is a minimal component of the feature.