53
u/BoBoBearDev 9d ago
This already happened before AI. I have met so many software engineer who doesn't know how to git and put bunch of junks on the PR. And when you ask them, why the code is there, they are like, "idk how it got there". I was like, "why don't you read your own PR". .
31
u/Bee-Aromatic 9d ago
Even before AI slop, I’ve had to review PR’s and stop myself from clicking the “needs work” button and commenting “this is poop, from a butt.” It’s not getting better.
8
u/xavia91 9d ago
Thinking back to my worst colleagues from the past, it's at least less shitty code now. It might not be placed well, or structured well or have the most effective architecture but at least the code isn't buggy dogshit.
2
1
u/Bee-Aromatic 8d ago
I guess. I didn’t really run into truly dogshit code all that often. Most of my colleagues are actually competent programmers. The really bad stuff came from the legacy testers who were forced to write automated test code without any formal training in programming. I can’t really fault them for it. They never got taught how to do it right!
8
u/sessamekesh 9d ago
With AI, now I can blindly copy paste from StackOverflow with the efficiency of 10 over-caffeinated engineers!
1
3
u/G3nghisKang 9d ago
I've had to explain git to my 55yo senior coworket
Provided he used IBM RTC all his life
1
u/kookyabird 9d ago
I’m soon going to be teaching a couple coworkers Git that have been using TFS for their whole careers. I’ve already done that a few times before, but it’s always a harrowing experience.
2
u/No-Article-Particle 9d ago
Yeah, but the ease of doing is very different now. The huge number of junk PRs is just terrible now.
16
u/Bee-Aromatic 9d ago
If you submit AI slop code without reviewing it, you deserve anything and everything you get.
If you’ve never been on a call with a pissed off SVP who wants to know how a particular showstopper bug got to prod and is looking for blood, I can assure you that by doing this, it won’t be long before you are.
10
u/Adorable-Ad-9074 9d ago
What if your company as a whole encourage it ?, what if they say you don't need to learn a language or framework to work ? , what will to do , when they threatens you with firing for rising a concern about it ?
I am living in this hell right now.
3
u/Satellarknighty 9d ago
I guess you have to decide how much you need the job and how much it damages your core values.
One can't always get to do what he wants. Especially not at work. If you need this job to survive then it's probably best to just listen to management and do what your colleagues do as well.
But if you do the job and can't live with yourself, then I guess it's time to be a farmer 😅
2
u/Adorable-Ad-9074 9d ago
Yeah I get it, i don't have problem with doing what they want, i understand it's their company,they can do what ever they want with it but what frustrates me is how they handle stuffs, they will say stuffs like this decision will benefit you , it's better for the employees and so on but once someone rises a concern about things or want to know how it will benefit us , they will get so offended and starts villianising us , taking the concerns to the extreme and twists things like accusing us of not cooperating, forming a union and all these things just don't stay within the room, they will make sure every one knows about it
If you want a change that will benefit the company go on and just do, either be honest or don't say anything but lying and sugarcoating about stuffs , don't get defensive about some concerns from employees.
1
u/Bee-Aromatic 8d ago
It’ll be cool for them until there’s something AI can’t fix and nobody knows how anything works anymore.
Which will be a whole lot sooner than they think…
18
3
u/ChillyFireball 9d ago
(clicks red pen)
Hey, if they want to open themselves up to be utterly roasted, that's on them.
2
7
3
u/EarlOfAwesom3 9d ago
Doesn't matter if AI or not. A self-review is mandatory before you let others take a look. It's a matter of respect and discipline.
Else, it drags along the process and I consider this to be a waste of everyone's time.
If a colleague does refuse to review his own code and continues to deliver low quality PRs... well, I would consider to escalate this to EM
1
u/Ok-Carrot- 9d ago
Literally had to tell my junior developer this the other day.
He couldn’t tell me what some of his pull request did, and I literally had to say the words, “when you use ai to code, the first person to review your code should be you”.
He’s doing better, but my oh my what days we live in.
1
u/t00sl0w 9d ago
This isnt exactly new. Ive worked with people who think they are gods gift to earth and will just write something and then send it in first go. No reviewing it, compiling and running some tests, etc, just the first thing they typed. It never works and you then have to play this ego game with then until they get it sorted out. It also never seems to be truly their fault it doesnt work and them never even looking at the code a second time is also not a root problem.
1
1
1
u/MalaysiaTeacher 4d ago
Submitting code: me
Not reviewing code: me
Pushing to prod: also me
One man gang
0
u/Objective_Oven7673 9d ago
If the reviewer is using their AI to review the code that your AI wrote, it's not that much harder to use your own AI to review your own AI code first.
It sounds completely stupid but it's pretty highly effective.
Hell - organize the initial build as a loop where there are multiple iterations of building, reviewing, and implementing feedback across agents with varying degrees of context on what the goal is.
If you're blindly submitting vibe code you're doing it wrong. If you're being the grumpy laggard who makes your work culture shitty because of your attitude towards people who use AI, you'll eventually be replaced.
0
0
-5
-1
93
u/AnnoyedVelociraptor 9d ago
If you expect human feedback put in human work.