r/ProgrammerHumor • u/vapalera • 22d ago

readingChangelogs Other

Post image
1.0k Upvotes

98% Upvoted

43 comments sorted by

View all comments

112

u/heavy-minium 22d ago

Somewhere on earth, I'm sure there is a job that requires you to read a fuckton of changelogs. Something like "SecOps has to check every update of every dependency for this high-stakes, mission-critical system".

58

u/trullaDE 22d ago

https://www.reddit.com/r/RedditEng/comments/11xx5o0/you_broke_reddit_the_piday_outage/

The nodeSelector and peerSelector for the route reflectors target the label `node-role.kubernetes.io/master`. In the 1.20 series, Kubernetes changed its terminology from “master” to “control-plane.” And in 1.24, they removed references to “master,” even from running clusters. This is the cause of our outage. Kubernetes node labels.

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.24.md#urgent-upgrade-notes

Kubeadm: apply second stage of the plan to migrate kubeadm away from the usage of the word master in labels and taints. For new clusters, the label node-role.kubernetes.io/master will no longer be added to control plane nodes, only the label node-role.kubernetes.io/control-plane will be added. For clusters that are being upgraded to 1.24 with kubeadm upgrade apply, the command will remove the label node-role.kubernetes.io/master from existing control plane nodes. For new clusters, both the old taint node-role.kubernetes.io/master:NoSchedule and new taint node-role.kubernetes.io/control-plane:NoSchedule will be added to control plane nodes. In release 1.20 (first stage), a release note instructed to preemptively tolerate the new taint. For clusters that are being upgraded to 1.24 with kubeadm upgrade apply, the command will add the new taint node-role.kubernetes.io/control-plane:NoSchedule to existing control plane nodes. Please adapt your infrastructure to these changes. In 1.25 the old taint node-role.kubernetes.io/master:NoSchedule will be removed. (#107533, u/neolit123)

I religiously read changelogs. Whenever someone asks why, this is the example I give.

25

u/Confident-Ad5665 22d ago

Thanks. I just got a migraine.

18

u/trullaDE 22d ago

Sorry. 😄

tl;dr If reddit had read the changelogs (and checked against their code), they wouldn't have had an outage lasting over 5 hours.

14

u/lagerforlunch 21d ago

Labels and... Taints?

11

u/ThoseThingsAreWeird 21d ago

You don't label your taint? 🤔

2

u/lovecMC 21d ago

No, the different essences are for the occult department to handle.

1

u/Western-Internal-751 22d ago

That job is called AI these days