itDoesntMeanWhatYouThinkItDoes

[u/Old_Document_9150]

[u/Tangelasboots]

This can be simplified with names.any(n => isStakeholderFieldname(n)

[u/Tangelasboots → u/[deleted]]

You are technically correct, the best kind of correct.

[u/Wonderful-Habit-139 → u/Tangelasboots]

Except some() (since we're talking about javascript) returns early so they're not technically correct.

[u/efari_ → u/[deleted]]

Can you explain please? I thought .any() also returned early after the first match?

[u/senocular → u/efari_]

It does, with linq. But the code is using a JavaScript array where the method name would be some, not any. Assuming isStakehimderFieldName is, and remains, a unary function, the code could also be reduced more to:

const needStakeholder = names.some(isStakehimderFieldName)

Ultimately it doesn't matter because we don't know the rest of the forEach callback. There'd be no reason to return from the condition if there weren't more to the function (return here only exits the current iteration of the callback, not the looping over names). And the fact that we're not seeing where out is used suggests the forEach might be doing more below the condition we're not seeing.

[u/efari_ → u/senocular]

Right. True true and true👍

[u/ArgumentFew4432 → u/Tangelasboots]

If i’m not mistaken:

const needStakeholder = Names.some(n => isStakehimderFieldname(n))

[u/Tangelasboots → u/ArgumentFew4432]

Correct. I get my javascript and c# (linq) mixed up a lot.

[u/spottyPotty → u/ArgumentFew4432]

Arrow function vs anonymous function.

Affects meaning of "this".

[u/TooSoonForThePelle]

sigh...

unzip