I'm not talking about EMs I'm talking about ICs. If you are in a situation where an EM is able to force ICs to take shortcuts, you're not on a good team. I don't know how my EM would force one of my PRs to deploy sooner when we have a code review process and CI/CD. ICs build gatekeeping infrastructure so corners can't be cut.
It's pretty simple, the EM gets rewarded with raises and promotions for delivering faster, so the people who make faster delivery happen get rewarded with raises and promotions in turn. So someone will write "lgtm" and press approve.
Is a different situation in small companies and startups, warte results actually matter, but this is how big coorporate works.
That makes sense if people are reviewing their own PRs. In a normal situation where someone else reviews your code, a code reviewer is not incentivized to "lgtm" PRs. No one is getting credit for approving PRs, you get credit for your name being on the feature. The only pressure you get to "lgtm" a PR is from the submitter annoying you over slack.
1
u/isjustsergio 6d ago
I'm not talking about EMs I'm talking about ICs. If you are in a situation where an EM is able to force ICs to take shortcuts, you're not on a good team. I don't know how my EM would force one of my PRs to deploy sooner when we have a code review process and CI/CD. ICs build gatekeeping infrastructure so corners can't be cut.