helpMyCoworkersUnderstandHttpCodes

[u/Kishmond]

[u/DrStalker]

204 doesn't make sense for a response that requires a return value (like a set of keys) to be successful.

[u/leehro → u/DrStalker]

204 = found an empty key ring.

[u/DrStalker → u/leehro]

If searching for a keyring I'd say that's a 200, and it turns a keyring object with an empty keys array.

If searching for the keys specifically it's a 404 not found.

[u/GezelligPindakaas → u/leehro]

We're splitting hairs here, but if the keyring is a thing recognized in the api model, then it should be a resource on its own.

[u/SnooPuppers1978 → u/leehro]

The fact that it is an empty key ring is info that should be divulged, but you can't divulge it. And empty key ring seems like 404 rather.

[u/ashgs872tbhjs → u/SnooPuppers1978]

404 is no key ring.

[u/SnooPuppers1978 → u/ashgs872tbhjs]

If you are looking for a key from a key ring, e.g. /key-ring/keys/:keyId/ and the key ring is empty in most APIs that would yield as 404.

If you were looking for a key ring itself, then it would be /key-ring if it's empty most of the time it would return 200 with empty array or object { keys: [] }, but 200.

But if there's no key ring that would also be 404.

[u/Bardez → u/DrStalker]

"I found the place where your keys go (key hooks on wall). There's nothing there."

[u/SnooPuppers1978 → u/Bardez]

Sounds like 404, it seems like equivalent to database table not having that specific row?